Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-320: Refactor theming of FilterBarButton #1589

Conversation

juliawegmayr
Copy link
Contributor

Screenshot 2024-01-17 at 14 12 42

@juliawegmayr juliawegmayr self-assigned this Jan 17, 2024
@auto-assign auto-assign bot requested a review from johnnyomair January 17, 2024 13:13
@juliawegmayr juliawegmayr force-pushed the refactor-theming-of-filterBarButton branch from 4d9a8bf to 920bf4c Compare January 22, 2024 16:09
Copy link
Contributor

@jamesricky jamesricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all deprecation notices stay directly above the deprecated things

Copy link
Contributor

@jamesricky jamesricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the conflict and make sure the deprecation notices are back where they belong.

@juliawegmayr juliawegmayr force-pushed the refactor-theming-of-filterBarButton branch from 05c1264 to abc910c Compare January 26, 2024 08:57
jamesricky
jamesricky previously approved these changes Jan 26, 2024
@johnnyomair
Copy link
Collaborator

@juliawegmayr please resolve conflicts. Thanks!

@juliawegmayr juliawegmayr force-pushed the refactor-theming-of-filterBarButton branch 2 times, most recently from 4a66f54 to 562a3ba Compare January 29, 2024 16:39
demo/admin/comet-config.json Outdated Show resolved Hide resolved
demo/site/comet-config.json Outdated Show resolved Hide resolved
@juliawegmayr juliawegmayr force-pushed the refactor-theming-of-filterBarButton branch from c8117c4 to 0935b87 Compare January 30, 2024 14:28
@johnnyomair johnnyomair changed the title COM-320 Refactor theming of FilterBarButton COM-320: Refactor theming of FilterBarButton Jan 30, 2024
@juliawegmayr juliawegmayr force-pushed the refactor-theming-of-filterBarButton branch 2 times, most recently from 879fa98 to 1955e50 Compare January 30, 2024 14:43
@juliawegmayr juliawegmayr force-pushed the refactor-theming-of-filterBarButton branch from 1955e50 to 263da79 Compare January 31, 2024 09:15
@johnnyomair johnnyomair merged commit ef8c531 into feature/refactor-admin-component-theming Jan 31, 2024
2 checks passed
@johnnyomair johnnyomair deleted the refactor-theming-of-filterBarButton branch January 31, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants